Change request #678

js_plugin::on_load does too much things

Added by David Demelier 11 months ago. Updated 8 months ago.

Status:ClosedStart date:08/14/2017
Priority:NormalDue date:
Assignee:David Demelier% Done:

100%

Category:IrccdEstimated time:1.00 h
Target version:3.0.0Spent time:2.00 h
MFD after: Bookmark:@
MFD revision: Submitted by:
Branch:default

Description

The current js_plugin::on_load function load the plugin, register variables and sets configuration, paths and formats. This should be done by user code since it does not allow this form of constructs in unit tests:

plg->set_config({});
plg->on_load();

Because on_load searches config and apply it, the initial set_config call is discarded.

Associated revisions

Revision 521:f253cf6a8ba8
Added by David Demelier 8 months ago

Irccd: do not set config in js_plugin load, closes #678

History

#1 Updated by David Demelier 8 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Resolved

#2 Updated by David Demelier 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF