Project

General

Profile

Change request #678

js_plugin::on_load does too much things

Added by David Demelier over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
irccd
Target version:
Start date:
08/14/2017
Due date:
% Done:

100%

Estimated time:
1.00 h
Spent time:
MFD after:
MFD revision:
Branch:
default
Bookmark:
@
Platform:

Description

The current js_plugin::on_load function load the plugin, register variables and sets configuration, paths and formats. This should be done by user code since it does not allow this form of constructs in unit tests:

plg->set_config({});
plg->on_load();

Because on_load searches config and apply it, the initial set_config call is discarded.

Associated revisions

Revision 521:f253cf6a8ba8 (diff)
Added by David Demelier over 1 year ago

Irccd: do not set config in js_plugin load, closes #678

History

#1

Updated by David Demelier over 1 year ago

  • % Done changed from 0 to 100
  • Status changed from New to Resolved
#2

Updated by David Demelier over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF