Change request #716

Change the way features are detected

Added by David Demelier 11 months ago. Updated 11 months ago.

Status:ClosedStart date:10/20/2017
Priority:NormalDue date:
Assignee:David Demelier% Done:

100%

Category:CMakeEstimated time:1.00 h
Target version:3.0.0
MFD after: Bookmark:@
MFD revision: Submitted by:
Branch:default

Description

The current CMake process is to define options, check if they are applicable and set/unset depending on the system availability. This leads to issues like:

  1. User runs CMake
  2. User sees that SSL support is disabled
  3. User install OpenSSL
  4. User re-run CMake

Problem: now the option of SSL is still deactivated because it has been forced off by CMake as cache variable.

Use the DefineOption and check the availability of features before settings options.

Associated revisions

Revision 512:d0893ea1f50b
Added by David Demelier 11 months ago

CMake: split options and conditions, closes #716

As described in the issue, the CMake process force off a cache variable
when a condition is not met. If the user installs the requirements and
re-run CMake it must also set the variable to on which is inconvenient.
The new process is to add a secondary variable and do not touch user
defined options.

History

#1 Updated by David Demelier 11 months ago

  • Description updated (diff)

#2 Updated by David Demelier 11 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Resolved

#3 Updated by David Demelier 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF